Skip to content

[TOOL-3497] Dashboard: Add Linked Wallets page in account layout, minor UI tweaks in account layout #6313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2025
Merged

[TOOL-3497] Dashboard: Add Linked Wallets page in account layout, minor UI tweaks in account layout #6313

merged 1 commit into from
Feb 22, 2025
+345 −115

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 21, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR primarily focuses on enhancing the account management features within the dashboard by implementing linked wallet functionality, improving UI components, and refining the overall user experience.

Detailed summary

  • Added a new route for Linked Wallets in layout.tsx.
  • Updated button text in AccountTeamsUI.tsx.
  • Changed <div> to <header> in AccountSettingsPage.tsx.
  • Enhanced Devices page layout in page.tsx.
  • Introduced getLinkedWallets API function in linked-wallets.ts.
  • Updated Page in wallets/page.tsx to fetch linked wallets.
  • Improved AccountDevicesPage.tsx layout and structure.
  • Enhanced LinkWalletUI component with a table format.
  • Added unlink wallet functionality with confirmation dialog in LinkWalletUI.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 21, 2025

TOOL-3497 Add linked wallets page in account layout

@vercel
Copy link

vercel bot commented Feb 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2025 1:28am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 22, 2025 1:28am
login ⬜️ Skipped (Inspect) Feb 22, 2025 1:28am
thirdweb_playground ⬜️ Skipped (Inspect) Feb 22, 2025 1:28am
wallet-ui ⬜️ Skipped (Inspect) Feb 22, 2025 1:28am

@vercel vercel bot temporarily deployed to Preview – login February 21, 2025 22:26 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 21, 2025 22:26 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 21, 2025 22:26 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 21, 2025 22:26 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5d345e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 21, 2025
@MananTank MananTank marked this pull request as ready for review February 21, 2025 22:26
@MananTank MananTank requested review from a team as code owners February 21, 2025 22:26
@MananTank Graphite App
Copy link
Member Author

MananTank commented Feb 21, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank changed the title [TOOL-3497] Dashboard: Add Linked Wallets page in account layout [TOOL-3497] Dashboard: Add Linked Wallets page in account layout, other UI tweaks in account layout Feb 21, 2025
@MananTank MananTank changed the title [TOOL-3497] Dashboard: Add Linked Wallets page in account layout, other UI tweaks in account layout [TOOL-3497] Dashboard: Add Linked Wallets page in account layout, minor UI tweaks in account layout Feb 21, 2025
graphite-app[bot]
graphite-app bot reviewed Feb 21, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (43638e5) to head (5d345e7).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6313   +/-   ##
=======================================
  Coverage   56.83%   56.83%           
=======================================
  Files        1168     1168           
  Lines       64793    64793           
  Branches     5258     5258           
=======================================
  Hits        36824    36824           
  Misses      27242    27242           
  Partials      727      727
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 43638e5
packages 55.04% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 211 ms (-34.53% 🔽) 1.2 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 607 ms (-2.4% 🔽) 3.1 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 117 ms (+498.03% 🔺) 229 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 109 ms (+1858.26% 🔺) 119 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 129 ms (+108.06% 🔺) 515 ms

@vercel vercel bot temporarily deployed to Preview – wallet-ui February 21, 2025 23:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 21, 2025 23:47 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 21, 2025 23:47 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 21, 2025 23:47 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 22, 2025 •
edited
Loading

Merge activity

@MananTank
[TOOL-3497] Dashboard: Add Linked Wallets page in account layout, min…
5d345e7 
…or UI tweaks in account layout (#6313)

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on enhancing the account management features in the dashboard by introducing linked wallets functionality, refining UI elements, and improving code organization.

### Detailed summary
- Added `/account/wallets` route with "Linked Wallets" label.
- Updated button text from "Create a Team" to "Create Team".
- Changed `<div>` to `<header>` in `AccountSettingsPage.tsx`.
- Enhanced `Devices` page structure with headers and descriptions.
- Implemented `getLinkedWallets` API function.
- Updated `Page` component to fetch linked wallets and account info.
- Refactored `LinkWallet` and `LinkWalletUI` components for better state management and UI.
- Added stubs for unlinking wallets in `LinkWalletsUI.stories.tsx`.
- Improved wallet unlinking functionality with confirmation dialogs.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – login February 22, 2025 01:21 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 22, 2025 01:21 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 22, 2025 01:21 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 22, 2025 01:21 Inactive
@graphite-app graphite-app bot merged commit 5d345e7 into main Feb 22, 2025
33 checks passed
@graphite-app graphite-app bot deleted the tool-3497 branch February 22, 2025 01:28
@vercel vercel bot temporarily deployed to Production – wallet-ui February 22, 2025 01:28 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 February 22, 2025 01:28 Inactive
@vercel vercel bot temporarily deployed to Production – login February 22, 2025 01:28 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 22, 2025 01:28 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@jnsdls jnsdls jnsdls approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls